Fix loan repay from salary attribute #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes frappe#146 Add `repay_from_salary` attribute to Loan object in Loan Management module. * **lending/loan_management/doctype/loan/loan.json** - Add `repay_from_salary` attribute to the fields list. - Set the `fieldtype` to "Check". - Set the `label` to "Repay From Salary". - Set the `default` to "0". * **lending/loan_management/doctype/loan/loan.py** - Add the `repay_from_salary` attribute to the `Loan` class. - Update the `validate` method to handle the `repay_from_salary` attribute. - Update the `set_missing_fields` method to handle the `repay_from_salary` attribute. * **lending/loan_management/doctype/loan/loan.js** - Add the `repay_from_salary` attribute to the `setup` method. - Update the `loan_application` method to handle the `repay_from_salary` attribute. * **lending/loan_management/doctype/loan/loan_dashboard.py** - Add the `repay_from_salary` attribute to the `get_data` method. * **lending/loan_management/doctype/loan/loan_list.js** - Add the `repay_from_salary` attribute to the `get_indicator` method. * **lending/loan_management/doctype/loan_repayment/loan_repayment.js** - Add the `repay_from_salary` attribute to the `setup` method.
|
@deepeshgarg007 Please look at this PR, this is important one. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
Add
repay_from_salaryattribute to Loan object in Loan Management module.lending/loan_management/doctype/loan/loan.json
repay_from_salaryattribute to the fields list.fieldtypeto "Check".labelto "Repay From Salary".defaultto "0".lending/loan_management/doctype/loan/loan.py
repay_from_salaryattribute to theLoanclass.validatemethod to handle therepay_from_salaryattribute.set_missing_fieldsmethod to handle therepay_from_salaryattribute.lending/loan_management/doctype/loan/loan.js
repay_from_salaryattribute to thesetupmethod.loan_applicationmethod to handle therepay_from_salaryattribute.lending/loan_management/doctype/loan/loan_dashboard.py
repay_from_salaryattribute to theget_datamethod.lending/loan_management/doctype/loan/loan_list.js
repay_from_salaryattribute to theget_indicatormethod.lending/loan_management/doctype/loan_repayment/loan_repayment.js
repay_from_salaryattribute to thesetupmethod.