Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output which kind of Stokes solver is used #6059

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

output which kind of Stokes solver is used #6059

wants to merge 2 commits into from

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Oct 8, 2024

fixes #6056

@tjhei
Copy link
Member Author

tjhei commented Oct 8, 2024

(need to update test output...)

@tjhei
Copy link
Member Author

tjhei commented Oct 8, 2024 •
edited
Loading

15% tests passed, 983 tests failed out of 1155

Hmmm. :-)

gassmoeller
gassmoeller reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean 15% of our tests are not solving the Stokes system? Interesting statistic 😆

source/simulator/solver.cc
if (parameters.use_direct_stokes_solver)
return "direct";
if (parameters.use_bfbt)
return "BFBT-AMG";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer "AMG-BFBT", because it is a modification of the AMG solver, which is the more important aspect. But I do not feel strongly about it, let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gassmoeller gassmoeller gassmoeller left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make it obvious what Stokes solver is used
2 participants
@tjhei @gassmoeller