fix WGPUInstanceEnumerateAdapterOptions, wgpuSwapChainGetCurrentTextureView & wgpuDevicePopErrorScope
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback must be called with `WGPUErrorType_NoError` type, when no error has occured.
fixes a potential leak of texture object.
almarklein
approved these changes
Jul 5, 2023
Beyley
pushed a commit
to Beyley/wgpu-native
that referenced
this pull request
Jul 15, 2023
…xtureView` & `wgpuDevicePopErrorScope` (gfx-rs#276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WGPUInstanceEnumerateAdapterOptionsshould takenextInChainpointer instead ofchain.wgpuDevicePopErrorScopeshould always call the callback, even when no error occured in the error scope.wgpuSwapChainGetCurrentTextureViewerrors in thetriangleexample.wgpuSwapChainGetCurrentTextureView.Testing
ran the examples on linux
fixes #275
fixes #267