fix macos arm64 build #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also don't set the xcode version manually, use default version from the runner-image.
almarklein
approved these changes
Jul 25, 2023
|
forgot to tag the release, tagged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently macos arm64 fails to set the correct
MACOSX_DEPLOYMENT_TARGET:https://github.com/gfx-rs/wgpu-native/actions/runs/5643538134/job/15285583834#step:6:1
SDKROOT: I am guessing it was needed before because building for Apple Silicon required beta xcode, which is not necessary anymore (I looked at rust-analyzer's release action).MACOSX_DEPLOYMENT_TARGETto11.0(first release to support Apple Silicon)Testing
resulting builds not tested, action was tested in my fork.