-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library to latest webgpu-native headers #427
Open
PJB3005
wants to merge
9
commits into
gfx-rs:trunk
Choose a base branch
from
PJB3005:24-09-19-update-headers
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 19, 2024
-
Update library to latest webgpu-native headers
This goes up to webgpu-native/webgpu-headers@2b59747 Things I *didn't* do: * I didn't update the library to make sure "instance dropped" callback error codes are guaranteed to happen, like they seem to be in Dawn. List of changes (roughly in order of header commits): Various enum and struct renames Updated callbacks to use the new *CallbackInfo structs and 2-userdata system. Also updated functions to return WGPUFuture, though the WGPUFuture thing is just stubbed out at the moment as I don't think wgpu-core has the necessary functionality for it. wgpuInstanceWaitAny is unimplemented!() DepthClipControl merged into PrimitiveState, related code simplified. Updated depthWriteEnabled to use an optional bool, mostly matters due to added validation. Add TODOs for missing features (sliced 3D compressed textures) *Reference() became *AddRef() Added unorm10-10-10-2 vertex format Usage field in TextureViewDescriptor, just used for validation as wgpu-core doesn't allow specifying it anyways. Removed maxInterStageShaderComponents Added clang_macro_fallback to bindgen config, since the headers switched to using UINT32_MAX etc. UINT64_MAX still doesn't work so I had to manually define those. Renamed flags enums. Added a conversion helper function to convert them from u64 -> u32 for mapping. (means added direct dependency on bitflags crate) Removed device argument from (unimplemented) wgpuGetProcAddress Suboptimal surface texture acquisition moved to enum return value, was easy since wgpu-core already returns it like that. "Undefined" present mode added, it just selects FIFO.
Configuration menu - View commit details
-
Copy full SHA for 2baea09 - Browse repository at this point
Copy the full SHA 2baea09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c60733 - Browse repository at this point
Copy the full SHA 0c60733View commit details -
Fix WGPUBufferMapAsyncStatus tomfoolery
This enum was replaced with WGPUMapAsyncStatus, but I didn't quite notice. The error codes map different.
Configuration menu - View commit details
-
Copy full SHA for 980c2ff - Browse repository at this point
Copy the full SHA 980c2ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f34e48 - Browse repository at this point
Copy the full SHA 8f34e48View commit details
Commits on Sep 27, 2024
-
Replaces *EnumerateFeatures with *GetFeatures. Also fixes CI due to fix in headers.
Configuration menu - View commit details
-
Copy full SHA for b36e558 - Browse repository at this point
Copy the full SHA b36e558View commit details -
Update wgpu.h to match new flag scheme
Upstream removed the "Flags" suffix from flags types and moved them to no longer be C enums. This matches that change. WGPUInstanceFlag still has "Flag" in the name because, well, there'd be nothing left to distinguish it from WGPUInstance, and it makes sense for it.
Configuration menu - View commit details
-
Copy full SHA for a4626db - Browse repository at this point
Copy the full SHA a4626dbView commit details
Commits on Oct 2, 2024
-
Update headers again, WGPUStringView
Also updates wgpu.h to use WGPUStringView everywhere.
Configuration menu - View commit details
-
Copy full SHA for a256544 - Browse repository at this point
Copy the full SHA a256544View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8947cf2 - Browse repository at this point
Copy the full SHA 8947cf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe965c8 - Browse repository at this point
Copy the full SHA fe965c8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.