fix(web)!: remove maxInterStageShaderComponents from vendored web-sys
#6377
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
approved these changes
Oct 7, 2024
jimblandy
approved these changes
Oct 7, 2024
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Oct 8, 2024
Revert the changes to the vendored copy of web-sys's WebGPU bindings made in gfx-rs#6377. The only purpose of vendoring is to pin down our WebGPU JS bindings, not to allow local changes. And as it turns out, removing the `max_inter_stage_shader_components` accessor isn't necessary in order to fix gfx-rs#6290.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Works around #6290. CC @daxpedda, who will likely be fielding a review in which I upstream this to
web-syseventually.Description
-
Testing
Tested locally that we are successfully working around the problem. Can be tested with
cargo xtask run-wasmand opening thehello_computeexample.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.