Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the unnecessary free disk space limit #4254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove the unnecessary free disk space limit #4254

wants to merge 1 commit into from

Conversation

paulsemel
Copy link
Collaborator

With Chromium archive sizes and extracted size being bigger, we cannot afford the 10GB surplus for the build directory.

@jonathanmetzman
Copy link
Collaborator

@oliverchang Do you know why we have these limits at all?

@paulsemel
Copy link
Collaborator Author

@oliverchang Do you know why we have these limits at all?

I decided to completely remove the limit. Let's wait for @oliverchang on why this was used, and I'll set this back if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang Awaiting requested review from oliverchang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsemel @jonathanmetzman