Update get_battery_level_and_temperature() #4300
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update regex to fetch a valid battery 'level' instead of 'Capacity level' to prevent timeout in wait_until_good_state() of battery.py
|
/gcbrun |
vitorguidi
reviewed
Oct 8, 2024
| @@ -40,7 +40,7 @@ def get_battery_level_and_temperature(): | |||
| output = adb.run_shell_command(['dumpsys', 'battery']) | |||
|
|
|||
| # Get battery level. | |||
| m_battery_level = re.match(r'.*level: (\d+).*', output, re.DOTALL) | |||
| m_battery_level = re.match(r'.*\n[\t ]*level: (\d+).*', output, re.DOTALL) | |||
There was a problem hiding this comment.
Can you write a simple unit test for this, so it becomes more explicit what kind of input we are expecting here? As someone who is not dealing with android on an everyday basis, it is hard to understand:
- Why the previous code broke
- Why this change solves the above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update regex to fetch a valid battery 'level' instead of 'Capacity level' to prevent timeout in wait_until_good_state() of battery.py