Resolve blocked domains to some IP #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrii
suggested changes
Sep 8, 2017
server.go
Outdated
| Ttl: 600, | ||
| } | ||
|
|
||
| a := &dns.A{rr_header, net.ParseIP("192.168.1.117").To4()} |
There was a problem hiding this comment.
You can't just use this random IP because it may be an actual IP to some user later. In an ideal world I would think we would just return an NXDOMAIN result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the browser does not keep showing "resolving..." for the blocked domains.
Let me know what you think!