Reactive GraphQL

[xareelee]

This PR is only for discussion about Reactive GraphQL we discussed before in the #647 (comment).

Here are what I did in January (sorry for delayed PR):

• Rewrite the graphql.js using RxJS to replace Promise-based graphql.js (all tests passed, you could run ). Run yarn run testonly-rx.
• Rewrite the graphql.js using most.js to replace Promise-based graphql.js (one test failed, still unresolved). Run yarn run testonly-most.
• Write benchmark.js to test the performance for Promise-based, RxJS-based and Most.js-based graphql(). Run yarn run benchmark.

Current progress:

• Finish a refactored graphql version for reactive programming.
• Pass tests (RxJS-based version)

Current Issues:

• The Most.js-based graphql() failed one test (has been reported at Unexpected raising error sequence cujojs/most#404).
• The RxJS-based and Most.js-based graphql() with reach a memory issue when running benchmark — "JavaScript heap out of memory"

TODO (if we agree to keep going this fork):

• Figure out the memory issues using RxJS and most.js with GraphQL.
• Make sure it is useful for real world and add more tests for reactive programming.
• Further refactoring to remove using exeContext.errors.push and use reactive Observable.error() instead of throw for error-handling.
• Rewrite the graphql.js with callback functions or our own version of Monad for Reactive Programming without any 3rd-party Rx dependency.
• Fix code for flowtype and lint.
• Make performance better (at least not significantly worst than Promise-based graphql).

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

[Birowsky]

@xareelee i would love to know whether there is any progress here or whether you figured out what caused the memory issue with rx.

[xareelee]

@Birowsky sorry, I'm working in ofo (China's biggest bike-sharing startup) and I'm too busy in this year.

[Birowsky]

@xareelee no problemo, have fun mate!

[stubailo]

BTW there's also this implementation by @DxCx: https://www.npmjs.com/package/graphql-rxjs

[leebyron]

For repo maintenance I'm going to close this issue. I'm happy to see the experimentation of a reactive executor in related github projects!

[alexstrat]

For anyone around here, I stumbled upon this very promising implementation and amazing work: https://github.com/mesosphere/reactive-graphql

👏