Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic validations to Login and Sign Up forms #451

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Add basic validations to Login and Sign Up forms #451

merged 3 commits into from
Oct 14, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Sep 13, 2023 •
edited
Loading

Fixes #445

Changes

  • Refactored the authentication page layout so that it doesn't double render the forms
  • installed React Hook Form to simplify handling form state and input validations
  • Renamed InputGroup to TextField to improve readability and increase specificity
  • Added basic validations according to the figma designs ( we can't do "account already exists" or "incorrect password" yet )
  • Broke Login and Sign up forms into discrete files to improve organization and modularity

Screenshots, if applicable

See input validation errors

image

image

@MattPereira MattPereira marked this pull request as ready for review September 22, 2023 00:32
@MattPereira MattPereira changed the title Draft for tw debugging Add basic validations to Login and Sign Up forms Sep 22, 2023
@MattPereira MattPereira mentioned this pull request Sep 22, 2023
Closed
3 tasks
@MattPereira MattPereira requested review from alexlaw528 and removed request for t-will-gillis October 10, 2023 23:59
bennyv8
bennyv8 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@bennyv8 bennyv8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Checked out branch and able to confirm functionalities.

@MattPereira
Copy link
Contributor Author

Thanks Benny!

@MattPereira MattPereira merged commit cc7323c into hackforla:main Oct 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyv8 bennyv8 bennyv8 approved these changes

@bzzz-coding bzzz-coding Awaiting requested review from bzzz-coding

@alexlaw528 alexlaw528 Awaiting requested review from alexlaw528

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add input validations to login and sign up forms
2 participants
@MattPereira @bennyv8