-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug causing deployment to fail with Poetry version > 1.3.0 #458
Bug causing deployment to fail with Poetry version > 1.3.0 #458
Conversation
dev/django.dockerfile
Outdated
@@ -9,7 +9,7 @@ WORKDIR /code | |||
SHELL ["/bin/bash", "-o", "pipefail", "-c"] | |||
|
|||
# Download Poetry into Path | |||
RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python3 - | |||
RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry | POETRY_VERSION=1.3.0 python3 - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with testing your hypothesis that the poetry version needs to be downgraded, but there may be a problem with the syntax
The CI checks shown at the bottom of PR are setup to prevent merging if any of them are failing
The linter thinks there's a problem with POETRY_HOME
and POETRY_VERSION
https://github.com/hackforla/CivicTechJobs/actions/runs/6570541381/job/17848134099?pr=458#step:7:125
closing and re-opening to re-run the CI checks just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexlaw528 Thanks so much for working on this issue and fixing the linting error! Now that the PR passed all checks, please go ahead and merge it ✨
2461d3e
to
7e35b50
Compare
)" This reverts commit 27d8621.
)" (#461) This reverts commit 27d8621. Co-authored-by: Alex Law <[email protected]>
Fixes #457
Changes