Fastapi conversion #807
Merged
Fastapi conversion #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_authentication.py` has tests that are being run against `moto`. Because moto is not behaving in an expected way, a couple of tests have been marked to be skipped.
Focuses on Intake Profile with Forms as a subcomponent of it.
The form definition endpoint has been moved to
`/api/intake-profile/form/{form_id}`. The JSON data is loaded from disk as a
stop gap until the Intake Profile feature is developed more.
The code for the responses endpoint has been moved but not updated. The
responses will be updated and viewed from the path
`/api/intake-profile/{intake_profile_id}`.
Matches the Intake Profile endpoints on the frontend and backend.
erikguntner
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #789
What changes did you make?
Updated
test_authentication- all tests passMigrated the following endpoints:
/coordinator/dashboard/all/host/forms-> Creating a form is not migrated as not being an immediate feature. The intake profile form definition is now located at/intake-profile/form/{profile_id}. The data loaded from disk until further development of Intake Profile and Forms makes progress. Updated frontend to use this path./responses-> Moved to/intake-profile/responses/{user_id}to put the focus on Intake Profile. Updated frontend to use this path./healthRationale behind the changes?
This is part of the FastAPI migration work. It migrates these endpoints from Flask to FastAPI.
Testing done for these changes