Auth invite and forgot password flow #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulespinosa
requested changes
Sep 30, 2024
|
Thanks @paulespinosa |
paulespinosa
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #789
What changes did you make?
Transferred '/auth/invite' , '/auth/confirmInvite', '/auth/new_password' endpoints and controllers from the old flask api to the new fast api. Updated the new controllers (invite, confirm_invite, new_password) to use pydantic request/response schemas. Added cookie schema for later which can be integrated into existing controllers dependent on team decision.
Rationale behind the changes?
Invite endpoint is needed to allow coordinators to invite new users to the application. Confirm invite endpoint is needed to allow new users to sign in through their email. New_password invite is needed to enable users to update their password.
Testing done for these changes
Integration tests will need to be implemented with Moto. I am having trouble testing the auth flow via the api docs in the browser because it is reliant on AWS Cognito and requires session tokens. I plan on looking at the Moto testing docs in the interim before bringing this up in the team meeting on Tuesday.