Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastapi conversion #818

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fastapi conversion #818

wants to merge 12 commits into from

Conversation

paulespinosa
Copy link
Member

@paulespinosa paulespinosa commented Oct 7, 2024 •
edited
Loading

Related #789

What changes did you make?

  • Started with clean Alembic migration environment and added migration script to insert roles into the database.
  • Create backend startup scripts to pre-populate the database and moto server with test user accounts.
  • Updated backend Dockerfile
  • Run the API using a script instead of directly in order to ensure test user accounts are populated before starting the API.
  • Updated docker-compose
    • Added moto server as a container
    • Added pgAdmin4 as a container

Rationale behind the changes?

Testing done for these changes

  • Run docker compose on development machine and manually checked that all services are integrated.
HUU-docker-environment HUU-pgadmin4 HUU-motoserver

@paulespinosa
fastapi-migration: Update docker
600495f
@paulespinosa
Merge branch 'main' into fastapi-conversion
307c4e2
@paulespinosa
fastapi-migration: Alembic, Docker, Test Users
e2d5170 
This commit updates alembic migrations, creates docker compose environment, and
creates test users for local development.
@paulespinosa
fastapi-migration: Fix API startup scripts
95daa18 
The create_groups_users.py program needed to get the db URL from the environment variable.
@paulespinosa
fastapi-migration: Update backend .env example
6220ba4 
The example has keys and values that can be used directly during development.
@paulespinosa
fastapi-migration: Update READMEs
d3c7edf
@paulespinosa
fastapi-migration: Remove commented frontend from docker compose
82c4b87 
In this commit, the frontend will still fail to build due to test errors.
However, that is being fixed in parallel and this will ensure that the frontend
will be able to run in a container when it does get fixed.
@paulespinosa
fastapi-migration: Update README about test users
581de6b 
This commit includes basic documentation about pre-populated test user accounts.
@paulespinosa
fastapi-migration: backend docker compose to depend on pgadmin
151c8e5 
By having the backend depend on pgadmin, the `db` container will transitively be
run too.
@paulespinosa
fastapi-migration: Update READMEs
6b5e65a 
Updated the service URLs.
@paulespinosa
Merge branch 'main' into fastapi-conversion
201e49f
@paulespinosa
fastapi-migration: Fix backend startup script duplication issue
b6904a3 
The backend startup scripts that pre-populated moto server was allowing
duplicate data to be added to moto. This happens when moto server is running
while the API is repeatedly started using the `entrypoint` script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikguntner erikguntner Awaiting requested review from erikguntner

@tylerthome tylerthome Awaiting requested review from tylerthome

@johnwroge johnwroge Awaiting requested review from johnwroge

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulespinosa