Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for setting uniqueId in Dialog to prevent duplicate creation #6737

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 30, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.20.x

What this PR does / why we need it:

Dialog API 支持传入 uniqueId,以限制同一时间仅打开一个。

Which issue(s) this PR fixes:

Fixes #6724

Does this PR introduce a user-facing change?

Dialog API 支持传入 uniqueId,以限制同一时间仅打开一个。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 30, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 30, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6737

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6737

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6737

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6737

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6737

commit: 52bc650

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.82%. Comparing base (982a45b) to head (52bc650).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6737      +/-   ##
============================================
- Coverage     58.29%   57.82%   -0.48%     
- Complexity     3963     3990      +27     
============================================
  Files           680      704      +24     
  Lines         23338    23737     +399     
  Branches       1584     1572      -12     
============================================
+ Hits          13604    13725     +121     
- Misses         9108     9390     +282     
+ Partials        626      622       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit c80ceb4 into halo-dev:main Sep 30, 2024
10 checks passed
@ruibaby ruibaby deleted the refactor/dialog-api branch September 30, 2024 09:45
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog 组件期望支持同时仅打开一个对话框
3 participants