Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: system initialization process to adapt to the new login method #6739

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 30, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

优化系统初始化流程以适配新的登录流程

Which issue(s) this PR fixes:

Fixes #6722
Fixes #5289

Does this PR introduce a user-facing change?

优化系统初始化流程以适配新的登录流程

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 30, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 30, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 30, 2024
Copy link

f2c-ci-robot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member Author

guqing commented Sep 30, 2024

@ruibaby 帮忙删除以前的 Console 初始化页面,并优化一下 resources/setup.html

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6739

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6739

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6739

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6739

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6739

commit: 830270d

@guqing guqing marked this pull request as ready for review October 8, 2024 08:03
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen October 8, 2024 08:03
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 18.43575% with 146 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (5b2bdfd) to head (830270d).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...halo/app/security/preauth/SystemSetupEndpoint.java 23.80% 80 Missing ⚠️
...in/java/run/halo/app/plugin/PluginServiceImpl.java 0.00% 26 Missing ⚠️
...a/run/halo/app/theme/service/ThemeServiceImpl.java 0.00% 19 Missing ⚠️
.../src/main/java/run/halo/app/infra/SystemState.java 0.00% 15 Missing ⚠️
.../main/java/run/halo/app/infra/utils/FileUtils.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6739      +/-   ##
============================================
- Coverage     58.00%   57.24%   -0.76%     
  Complexity     3977     3977              
============================================
  Files           696      708      +12     
  Lines         23517    23906     +389     
  Branches       1567     1569       +2     
============================================
+ Hits          13641    13685      +44     
- Misses         9255     9609     +354     
+ Partials        621      612       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024
Copy link

f2c-ci-robot bot commented Oct 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

重构系统初始化页面 通过 jar 运行时,无法安装预设插件
2 participants