To merge #1
Open
To merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Spanish from Spain translation
…-a-dependency-for-building Add gettext as a build dependency. (fixes #410)
Add "--gog" option to Innoextract for Windows game.
* Don't fail installation if xml checksum data isn't available * Remove double test * Remove another double test * Prevent exception from xml data download * Simplify xml data code
Co-authored-by: Maxime Lombard <[email protected]>
When using minigalaxy, some games tend to freeze after a few minutes. When running them manually, from a terminal, I can't reproduce the freeze. This is the case, at least, for "Darkest Dungeon" and "Slay the Spire". This issue seems to be related to how the `subprocess.Popen` call is done when launching the game. `stdout` and `stderr` are set to `subprocess.PIPE`, but `subprocess.PIPE.communicate` is called only once if the game is not running after a 3s delay. The subprocess output is filling an internal buffer and the game hangs when this buffer is full. Now, stderr is merged in stdout, and a new thread is started to consume the subprocess stdout and send it to the parent process stdout. A thread is created in order to avoir blocking the main UI thread.
* Delete all offline installer files. * Fix test Co-authored-by: Wouter Wijsman <[email protected]>
Use DLC icon cache
This file will be the source of truth for this project and thus should always be parsable.
Make changelog builder able to deal with special characters
Updated Greek Translation
For some users, XDG_CACHE_HOME may not be large enough to accomodate complete offline installers for some games. Provide such users with a way to use a different directory when downloading games. Instead of polluting the preferences menu with another option, get this setting from an environment variable.
The DLC installer info gets lost when downloading Windows games. As a result, the base game is downloaded. Preserving that info fixes the error.
Installers for Windows games that are larger than 4 gigabytes in size are split into multiple files. When multiple threads are used to download these files in parallel, special care must be taken to run the installer only when all the files are fully downloaded, not just the main executable.
If multiple threads start their downloads into the same directory, they can call os.mkdirs at the same time, leading to "File exists" exceptions and subsequent failures to download some files. Fix this by supplying an exist_ok argument and removing the racy isdir check.
Bump version to 1.3.0 and describe the recent changes.
I considered making this an issue, but I figured I could just write the change, and you can decline the pull request if you don't want it. I only noticed today that Minigalaxy has what seems to be an official & maintained release on Flathub. However, it is not mentioned on the README/website. I added a section under Installation for Flatpak like the other entries. This would help make sure people don't miss this option.
Adding Flatpak to README
Fix Windows games installation
Fix Remove forward slash from desktop filename (Shenzhen I/O)
Signed-off-by: Artem Polishchuk <[email protected]>
Remove deprecated attributes from AppData
Signed-off-by: Artem Polishchuk <[email protected]>
Remove unused <li/> tag in AppData
Added pt_PT
Portuguese translation
Update constants.py
Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As automatic upstream merge is not possible.