Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: begin epoch 3.0 block times at start height - 1 #43

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

obycode
Copy link
Member

@obycode obycode commented Sep 6, 2024

This allows the extra time needed during the switchover to Nakamoto.

docker-compose.yml Outdated Show resolved Hide resolved
Copy link

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me 👍 Epoch 3 times will typically have slower times for bitcoin

@janniks
Copy link

janniks commented Sep 27, 2024

@obycode what behavior where you seeing in these cases? Would the network/node stall at the Epoch3 switch-height, or later?

@obycode
Copy link
Member Author

obycode commented Oct 1, 2024

what behavior where you seeing in these cases? Would the network/node stall at the Epoch3 switch-height, or later?

Just a missed block at the switch height, which is not a problem, but could cause unnecessary confusion.

@obycode obycode merged commit 22d8734 into main Oct 1, 2024
2 of 3 checks passed
@obycode obycode deleted the fix/epoch3-block-times branch October 1, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants