Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to specific extra refinery commands #265

Merged
merged 2 commits into from
Jul 11, 2023
Merged

feat: Add ability to specific extra refinery commands #265

merged 2 commits into from
Jul 11, 2023

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

  • Inability to specify any refinery commands, such as --no-validate

Short description of the changes

  • add new extraCommandArgs field.
  • apply extraCommandArgs field to refinery command args.

How to verify that this has the expected result

Manual test with local kind cluster

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner July 10, 2023 19:17
@TylerHelmuth TylerHelmuth merged commit c7da8a8 into main Jul 11, 2023
4 checks passed
@TylerHelmuth TylerHelmuth deleted the tyler.refinery-extra-args branch July 11, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerHelmuth @kentquirk