Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch/consistent-naming-ingressClassName #278

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

patch/consistent-naming-ingressClassName #278

wants to merge 7 commits into from

Commits on Jul 19, 2023

  1. Update ingress-grpc.yaml 

    Make ingress.className to ingressClassName to be consistent with ingress.yaml file
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1bfd0c4 View commit details
    Browse the repository at this point in the history

  2. Update ingress-beta.yaml 

    Make ingress.className to ingressClassName to be consistent with ingress.yaml
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b7efd80 View commit details
    Browse the repository at this point in the history

  3. Update ingress-beta.yaml 

    Revert change to ingress-beta.yaml
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d1842fc View commit details
    Browse the repository at this point in the history

  4. Update ingress-grpc.yaml 

    Update ingress-grpc based on PR feedback
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f377874 View commit details
    Browse the repository at this point in the history

  5. Update ingress.yaml 

    Update based on PR feedback
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4b73986 View commit details
    Browse the repository at this point in the history

  6. Update NOTES.txt 

    Fail if ingressClassName is set, per PR comment
    @zenon-was-here
    zenon-was-here authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    66f926a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Update values.yaml 

    Add empty string `className:` fields to ingress and grpcIngress values
    @zenon-was-here
    zenon-was-here authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    696bb0a View commit details
    Browse the repository at this point in the history