Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel: Prepare 3.0.0 pre-release #357

Merged
merged 23 commits into from
May 6, 2024
Merged

Conversation

TylerHelmuth
Copy link
Contributor

@TylerHelmuth TylerHelmuth commented Apr 23, 2024

Prepares an "internal" release of the chart for us to test Refinery 3.0.0.

⚠️ We do not recommend any customer use this version of the chart and we do not support it.

Changes:

zenon-was-here and others added 10 commits July 18, 2023 22:05
Make ingress.className to ingressClassName to be consistent with ingress.yaml file
Make ingress.className to ingressClassName to be consistent with ingress.yaml
Revert change to ingress-beta.yaml
Update ingress-grpc based on PR feedback
Update based on PR feedback
Fail if ingressClassName is set, per PR comment
Add empty string `className:` fields to ingress and grpcIngress values
@TylerHelmuth TylerHelmuth changed the title Prepare 3.0.0 release rel: Prepare 3.0.0 release Apr 23, 2024
@TylerHelmuth TylerHelmuth changed the title rel: Prepare 3.0.0 release rel: Prepare 3.0.0 pre-release Apr 23, 2024
@VinozzZ
Copy link
Contributor

VinozzZ commented May 6, 2024

This is the refinery value I used in my local testing environment

CentralStore:
    Type: redis
    SpanChannelSize: 10_000

  RedisPeerManagement:
    # Host is the host and port of the Redis instance to use for peer cluster membership management.
    Host: '{{include "refinery.redis.fullname" .}}:6379'
    MaxIdle: 30
    MaxActive: 100

  Collection:
    # AvailableMemory is the amount of system memory available to the Refinery process.
    MaxAlloc: '{{ .Values.resources.limits.memory }}'
    AvailableMemory: '{{ .Values.resources.limits.memory }}'
    MaxMemoryPercentage: 75
    # TraceFetcherConcurrency: 2
    ProcessTracesBatchSize: 1000
    DeciderBatchSize: 1000

replicaCount: 6

resources:
  limits:
    cpu: 5
    # This value is used by default for config.Collection.AvailableMemory
    memory: 2Gi
  requests:
    cpu: 500m
    memory: 500Mi

Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this in Zoom

@TylerHelmuth TylerHelmuth marked this pull request as ready for review May 6, 2024 20:24
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner May 6, 2024 20:24
@TylerHelmuth TylerHelmuth merged commit 837251e into main May 6, 2024
3 checks passed
@TylerHelmuth TylerHelmuth deleted the tyler.prepare-3.0.0-release branch May 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants