feat(refinery): add support for topologySpreadConstraints #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
type: enhancement
|
@TylerHelmuth can we get some ❤️ ❤️ here. Thanks. |
|
Thanks for this @nakamume ! At a glance this seems reasonable but I'm looking into whether there's any reason we haven't done it yet (is it just time/resources or something else?). I'd think this should be a feature (feat) not a chore, with a minor bump instead of a patch. And it looks like this would close #97 so we can link that up as well. |
JamieDanielson
changed the title
TylerHelmuth
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
topologySpreadConstraintsfor Refinery Helm Chart #97Short description of the changes
Adds support for providing
topologySpreadConstraintsfield. This will help us deploy refinery confirming to some topology constraints.