Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

API cleanup #50

wants to merge 3 commits into from

Conversation

codemasher
Copy link
Contributor

Ok so that's the last change proposal for now, for a future v3.x.

  • It removes the abstract classes and traits - each test is now self-contained in order to ease extending if necessary.
  • Further, all properties and methods have type hints added.
  • Some superfluous assertions (such as assertInstanceOf for objects received from the factory methods with return types) and custom assert methods have been removed.
  • Properties that hold instances of the factory methods are now named after the factory ($requestFactory vs. $factory).
  • I made 3 separate commits so that the change history remains traceable.

I've spent more time for this now than I planned - I'm back on qrcode stuff if you need me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant