Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposes alt definition blockNumber #1696

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

m4sterbunny
Copy link
Contributor

@m4sterbunny m4sterbunny commented Sep 25, 2024

Description

This is an ad-hoc pass -- setting up expanded descriptions for Linea == using Besu as sot. If I find something in sot, raising it as proposal here.

  1. alt definition for blockNumber: tested (large) digital integer using Linea:Besu got: :{"code":-32602,"message":"quantity values must start with 0x"

curl -X POST https://linea-mainnet.infura.io/v3/<"key">
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_getBlockByNumber",
"params": [
"5237789",
false
],
"id": 1
}'

  1. eth_getBlockReceipts --> blockHash is accepted not just number + tag
    curl -X POST https://linea-mainnet.infura.io/v3<"key">
    -H "Content-Type: application/json"
    -d '{
    "jsonrpc": "2.0",
    "method": "eth_getBlockReceipts",
    "params": [{
    "blockHash": "0xd459570b5d2994a81ec1875b058f665b7f9c006172a8bd2860de87aee9569ac8"
    }],
    "id": 1
    }'

Issue(s) fixed

  1. eth_feeHistory
    A
    Passing the percentile array as optional fails
    curl -X POST https://linea-mainnet.infura.io/v3/<"key">
    -H "Content-Type: application/json"
    -d '{
    "jsonrpc": "2.0",
    "method": "eth_feeHistory",
    "params": [
    "0x5",
    "latest",
    ],
    "id": 1
    }'

While empty array passes
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_feeHistory",
"params": [
"9964064",
"latest",
[]
],
"id": 1
}'

B
The result object schema says oldestBlock is integer, but my result provides Hexademical of the integer, i.e a string
result:
name: eth_feeHistoryLineaExampleResponse
value:
type: object
schema:
properties:
oldestBlock: '0x10b52f'

  1. eth_getTransactionCount
    tested and response is not integer
    curl -X POST
    https://linea-mainnet.infura.io/v3/<"key">
    -H "Content-Type: application/json"
    -d '{
    "jsonrpc":"2.0",
    "method":"eth_getTransactionCount",
    "params": [
    "0x188e0B45cedd8f5e425e73c8aa7953b92115ec24",
    "0x4fb66d"
    ],
    "id":1
    }'

{"jsonrpc":"2.0","id":1,"result":"0x52"}%

Fixes #1695

Preview

@m4sterbunny m4sterbunny requested a review from a team as a code owner September 25, 2024 17:43
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:52am

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m4sterbunny m4sterbunny marked this pull request as draft October 1, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nitpicks
2 participants