Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the --interface argument when broadcasting for scheduler discovery #544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torokati44
Copy link

This PR aims to (at least partially) solve #538.
It does not add any filtering for incoming packets, but at least the daemon won't look for schedulers on any interface other than the one given as command line argument (if one is given...).
It might not be perfect yet, because the naming of the new variables might be confusing here and there, and the value of the --interface option has to be passed around a lot in all sorts of places, but I'm open to suggestions for improvement.
Maybe adding some comments would be enough to explain what the new variables/parameters are there for?
Also, this might break icemon.

@llunak
Copy link
Contributor

llunak commented Jul 17, 2020

The patch in principle looks good, but can you please make sure it's backwards source compatible (i.e. that icemon compiles without changes)? In some cases it's not necessary at all to pass the extra argument (e.g. DiscoverSched::sendSchedulerDiscovery() can use the member variable), in other cases it can be the last argument with a default value (which mostly will be also better API, with the argument not being very important in the argument list).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants