Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ReadAsync in ZipAESStream, extra simple version #579

Merged
merged 2 commits into from
May 8, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Feb 14, 2021

Possible extra trivial version of #576, just for testing and a potential quick fix (whereby it doesn't attempt to actually be async)

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy
Copy link
Contributor Author

Numpsy commented Mar 14, 2021

@piksel Any thoughts on applying the simple approach as a quick fix for for #572, given that I don't think a 'full' async version would actually do async reads at this point unless PartialInputStream was made async as well (ref #589)?

(It'd be nicer to make everything more fully async, not sure if there's any thoughts of a timespan for a next maintenance release vs. doign that though)

@piksel
Copy link
Member

piksel commented Mar 15, 2021

Yeah, I agree. Having the "stub" async override in the code base until another way is implemented is definitively better than trying to solve this correctly before doing anything.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #579 (525555e) into master (7ed87d1) will increase coverage by 2.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   70.96%   73.05%   +2.08%     
==========================================
  Files          68       68              
  Lines       13417     8724    -4693     
==========================================
- Hits         9522     6373    -3149     
+ Misses       3895     2351    -1544     
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.00% <100.00%> (+2.44%) ⬆️
...pZipLib/Core/Exceptions/StreamDecodingException.cs 60.00% <0.00%> (-6.67%) ⬇️
...pLib/Core/Exceptions/StreamUnsupportedException.cs 60.00% <0.00%> (-6.67%) ⬇️
.../Core/Exceptions/UnexpectedEndOfStreamException.cs 60.00% <0.00%> (-6.67%) ⬇️
src/ICSharpCode.SharpZipLib/Checksum/Adler32.cs 81.81% <0.00%> (-3.29%) ⬇️
...pCode.SharpZipLib/Zip/Compression/PendingBuffer.cs 74.13% <0.00%> (-3.14%) ⬇️
.../ICSharpCode.SharpZipLib/Core/FileSystemScanner.cs 48.73% <0.00%> (-2.91%) ⬇️
...e.SharpZipLib/Zip/Compression/InflaterDynHeader.cs 91.48% <0.00%> (-2.17%) ⬇️
...harpZipLib/Zip/Compression/Streams/OutputWindow.cs 67.74% <0.00%> (-2.07%) ⬇️
src/ICSharpCode.SharpZipLib/Core/PathFilter.cs 10.25% <0.00%> (-1.46%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed87d1...525555e. Read the comment docs.

@Numpsy Numpsy marked this pull request as ready for review April 25, 2021 20:41
@Numpsy Numpsy changed the title [WIP] Implement ReadAsync in ZipAESStream, extra simple version Implement ReadAsync in ZipAESStream, extra simple version Apr 25, 2021
@piksel piksel merged commit 7ac1fda into icsharpcode:master May 8, 2021
@Numpsy Numpsy deleted the rw/async/simple_aes_read branch May 8, 2021 20:59
HowToDoThis added a commit to HowToDoThis/SharpZipLib that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants