Stripe subscription updates (amount/schedule) #80
Conversation
VSydor
force-pushed
the
feature/stripe-subscritpion-update
branch
3 times, most recently
from
3a0c1ff
to
ab108a3
Compare
| @@ -158,6 +158,7 @@ default Optional<CrmRecurringDonation> getRecurringDonation(PaymentGatewayEvent | |||
| return getRecurringDonationBySubscriptionId(paymentGatewayEvent.getSubscriptionId()); | |||
| } | |||
| String insertRecurringDonation(PaymentGatewayEvent paymentGatewayEvent) throws Exception; | |||
| void updateRecurringDonation(PaymentGatewayEvent paymentGatewayEvent) throws Exception; | |||
There was a problem hiding this comment.
@VSydor Hey! @Levi-Lehman and I were talking on #75 (comment) about something similar. With what we're doing on that other PR, we'll wind up with a set of methods like this:
updateRecurringDonation(CrmRecurringDonation)
updateRecurringDonation(PaymentGatewayEvent)
updateRecurringDonation(ManageDonationEvent)
In the CrmService impls, all 3 of them wind up with similar code (sometimes minor differences). Starting to think through refactors that will square all that up. Ex: rather than all the separate fields in PaymentGatewayEvent, nest CrmRecurringDonation as a field inside that event, then persist directly from a default method in CrmService? That's exactly what we do with CrmAccount and CrmConact in PaymentGatewayEvent currently...
Any other ideas?
There was a problem hiding this comment.
Makes sense - let's have it this way ("what we do with CrmAccount and CrmConact in PaymentGatewayEvent currently")
VSydor
force-pushed
the
feature/stripe-subscritpion-update
branch
from
ab108a3
to
b2b1483
Compare
No description provided.