Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multihashes with DBL_SHA2_256 code #197

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

gammazero
Copy link
Collaborator

The double hash multicodec code is not dedicated to encrypted records. Therefore we cannot implicitly assume that it represents one.

The double hash multicodec code is not dedicated to encrypted records. Therefore we cannot implicitly assume that it represents one.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (c72e65b) to head (be5a34b).

Files Patch % Lines
store/dhstore/dhstore.go 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   55.50%   55.69%   +0.19%     
==========================================
  Files          20       20              
  Lines        2908     2898      -10     
==========================================
  Hits         1614     1614              
+ Misses       1067     1057      -10     
  Partials      227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 7bf79d7 into main Mar 29, 2024
7 checks passed
@gammazero gammazero deleted the allow-dh-multihash branch March 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants