Check for a file to disable testing a specific Java level if the prop… #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
force-pushed
the
jdk-test-exclusion
branch
from
280cc07
to
082fe0d
Compare
…erty is defined rather than looking for a file to enable the profile. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
jdk-test-exclusion
branch
from
082fe0d
to
19dbbce
Compare
Signed-off-by: James R. Perkins <[email protected]>
|
Seems OK in principle, once the bugs are worked out. I guess a lot of the test projects aren't testing on all available versions. Also you'd want to limit it so that you don't test on a version earlier than the minimum supported version (this is in a property IIRC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erty is defined rather than looking for a file to enable the profile.
The idea here is to enable the test profiles by default if the
javaXX.homeproperty is set unless adisable-test-javaXXfile is defined. This allows testing with different Java versions by default instead of having to add files to each module of a multi-module project when you want to test a new Java version.