remove dependency on @uupaa/dynamic-import-polyfill
#6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Please, change your base branch to master, I think no more PR will be merged to 10.9 since it's freeze now |
Removed the dependency on `@uupaa/dynamic-import-polyfill` and switched to using raw `import()`, because the polyfill were having issues with `async`/`await` in plugin modules which were using `await` at the top-level in the module to e.g. do dynamic imports because plugins don't have a base-point to do static imports of other modules.
revam
force-pushed
the
remove-import-module-package
branch
from
ee2972a
to
89613fc
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Moved to |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed the dependency on
@uupaa/dynamic-import-polyfilland switched to using rawimport(), because the polyfill were having issues withasync/awaitin plugin modules which were usingawaitat the top-level in the module to e.g. do dynamic imports because plugins don't have a base-point to do static imports of other modules.Issues