-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add media segment skipping #6157
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
private debouncedOnTimeUpdate = throttle(this.handleSegmentActions, 500, { leading: true }); | ||
|
||
private async fetchMediaSegments(api: Api, itemId: string, includeSegmentTypes: MediaSegmentType[]) { | ||
// FIXME: Replace with SDK getMediaSegmentsApi function when available in stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected 'fixme' comment: 'FIXME: Replace with SDK...'. no-warning-comments
9a4420b
to
91de060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Just some things I noted when testing:
|
From my initial testing, this reliably skips intros, but it has not skipped outros or previews. I'm going to create some test media so I can test the other segment types. |
It looks like all segments after the first will not be skipped because
|
91de060
to
54713f9
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Cloudflare Pages deployment
|
The latest commit is skipping intro, outro, and preview segments reliably. I haven't gotten a chance to create test media with other segment types, but I don't see why those wouldn't also skip. |
I created some test media for recap and commercial segments, which were also skipped. |
Changes
Needs cleanup + testing so marking as a draft for now
Issues
N/A