Added Units + Lang Support for Chapter Interval Metadata Setting #6158
+286
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cloudflare Pages deployment
|
dmitrylyzo
reviewed
Oct 3, 2024
| <div class="fieldDescription">${LabelDummyChapterDurationHelp}</div> | ||
|
|
There was a problem hiding this comment.
Remove the blank line - don't make unrelated changes.
| @@ -22,8 +22,9 @@ <h2 style="margin-top:0;">${HeaderPreferredMetadataLanguage}</h2> | |||
| <div class="verticalSection"> | |||
| <h2>${HeaderDummyChapter}</h2> | |||
| <div class="inputContainer"> | |||
| <input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration}" min="0"></input> | |||
| <input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration} ${LabelUnits}" min="0 seconds"></input> | |||
There was a problem hiding this comment.
LabelUnits is too generic. Maybe add unit to LabelDummyChapterDuration?
| } | ||
| "HearingImpairedShort": "HI/SDH", | ||
| "LabelUnits": "(sekondes)" | ||
| } |
There was a problem hiding this comment.
Revert changes to languages other than en-us. Only Weblate should be used to work with other languages.
| @@ -22,8 +22,9 @@ <h2 style="margin-top:0;">${HeaderPreferredMetadataLanguage}</h2> | |||
| <div class="verticalSection"> | |||
| <h2>${HeaderDummyChapter}</h2> | |||
| <div class="inputContainer"> | |||
| <input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration}" min="0"></input> | |||
| <input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration} ${LabelUnits}" min="0 seconds"></input> | |||
There was a problem hiding this comment.
The value of the min attribute is invalid
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Used translation script to add seconds text to all json str files. Called from metadataimages.html to show units
Issues
#5555
ex. Fixes # -->#5555