Parallel repeats and protection from infinite crash loop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
reviewed
Apr 8, 2020
| if (self.config.cloneSimulator) { | ||
| self.testHostForSimUDID = [bpSimulator createSimulatorAndInstallAppWithBundles:xcTestFiles]; | ||
| if ([self.testHostForSimUDID count] == 0) { | ||
| return 1; | ||
| } | ||
| } | ||
|
|
||
| int repeatTestsCount = [self.config.repeatTestsCount intValue]; |
There was a problem hiding this comment.
Won't this PR add repeat test count 2x?
There was a problem hiding this comment.
Oh, you're right. I think it was a bad merge. Updating.
…ow repeats to run in parallel when there are few tests
Also log when retry count exceeded max retries
RainNapper
force-pushed
the
mmark/11.2.1
branch
from
f4184c8
to
08bbba4
Compare
|
LGTM! |
|
@RainNapper is there any test coverage for this PR? I think it's going to end up running the same test over and over even if it didn't fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked changes from these two PRs.
MobileNativeFoundation#432
MobileNativeFoundation#431