Fix spurious "File Changed" dialog in JupyterLab 4.1+/Notebook 7.1+

[krassowski]

• fixes Hitting Command(Ctrl) + S on in an RTC notebook results in a "File Changed" dialog #312
• fixes Renaming a notebook results in a "File Changed" dialog #313
• fixes Often hit "File Changed" prompt when running with jupyterlab>=4.1.0 #317
• requires a PR to jupyter_ydoc to add hash setter Add hash property with setter and getter jupyter-server/jupyter_ydoc#262
• requires to set the hash on frontend; we can emit fileChanged signal from drive and this gets passed down to the context which stores the hash; this requires Update contents model on file change due to save from RTC jupyterlab#16695

[github-actions]

👈 Launch a Binder on branch krassowski/jupyter_collaboration/fix-spurious-save-dialog

[davidbrochart]

LGTM

[davidbrochart]

Now that we use the file hash, we could use it to check if the server was the one who saved the file last, instead of using timestamps (see jupyter-server/jupyter_server#1367 (comment) and jupyterlab/jupyterlab#14031 (comment)). This could be done in another PR.

[krassowski]

I will address this one before merging.

[shrutiagarwal13]

Hi team,
I tried installing jupyter-collaboration v3.0.0beta3 with JupyterLab 4.1.0, and jupyter-collaboration v3.0.0beta6 with JupyterLab 4.2.5, hoping to resolve the 'File Changed' dialog issue. However, I am still encountering this problem. Any insights or suggestions would be greatly appreciated!

Attaching the screenshot for reference:

[krassowski]

@shrutiagarwal13 you need JupyterLab 4.3.0b1 and jupyter-ydoc v3.0.0a4. If it does not work with these versions and jupyter-collaboration pre-release let me know.

[shrutiagarwal13]

@krassowski thanks for reaching out. While the issue occurs less frequently now, I still encounter errors in certain scenarios, as shown in the attached screen recording. This tends to happen when pressing 'Ctrl+S' multiple times.

The following package versions are installed:

$ pip list | grep jupyter
jupyter_client               8.6.1
jupyter-collaboration        3.0.0b3
jupyter-collaboration-ui     1.0.0b6
jupyter_core                 5.7.2
jupyter-docprovider          1.0.0b6
jupyter-events               0.10.0
jupyter-lsp                  2.2.5
jupyter-resource-usage       1.1.0
jupyter_server               2.14.0
jupyter_server_fileid        0.9.3
jupyter-server-mathjax       0.2.6
jupyter_server_proxy         4.4.0
jupyter_server_terminals     0.5.3
jupyter-server-ydoc          1.0.0b6
jupyter-telemetry            0.1.0
jupyter-tensorboard-proxy    0.2.1
jupyter-vscode-proxy         1.0.0
jupyter-ydoc                 3.0.0a4
jupyterhub                   4.1.5
jupyterlab                   4.3.0b1
jupyterlab_git               0.50.1
jupyterlab-logout            1.0.0
jupyterlab_pygments          0.3.0
jupyterlab-s3-browser        0.12.0
jupyterlab_server            2.27.1
jupyterlab-theme-toggler     1.0.0
jupyterlab_widgets           3.0.13

JLab_Collab_Error3.mp4