-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bump file #343
base: main
Are you sure you want to change the base?
Fix bump file #343
Conversation
Any clue on the check-release failure ? I can't reproduce the steps locally, so it's hard to debug. |
This seems to be failing as part of the Which was also noticed in voila-dashboards/voici#106. A workaround for now could be to disable the |
Thanks for your feedback @jtpio.
I'll see if I can find a way to keep this check, otherwise we'll probably ignore it until there's a fix on the releaser. |
So instead of skipping the |
It looks like we are missing the pre-release specifier:
|
Yes, we still have an issue because of the releaser that doesn't allow installing local python package with pip (AFAIK): #343 (comment) |
So do you think we should merge anyway? |
It would be better to get that |
Fix the dependencies in
jupyter_collaboration
metapackage, and fix the bump script.Initially discussed at #342 (comment)
cc. @krassowski