fix: potential command injection #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by refactoring envs as option Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
adeherysh
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
...by refactoring envs as option.
Why are we doing this? Any context or related work?
security implication, potentially command injected thru env vars.
Where should a reviewer start?
optional -- if your changes affected so much files, it is encouraged to give helper for reviewer
Screenshots
optional -- You may put the database, sequence or any diagram needed
Manual testing steps?
Steps to do tests. including all possible that can hape
Config changes
optional -- If there's config changes, put it here
Deployment instructions
optional -- Better to put it if there's some 'special case' for deployment