Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Store Kitodo war file as build artifact for download #6128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stweil
Copy link
Member

@stweil stweil commented Jul 17, 2024

No description provided.

@stweil stweil requested a review from solth July 17, 2024 18:41
@stweil
Copy link
Member Author

stweil commented Jul 17, 2024

See example. CI artifacts are always ZIP files. In this case it is the ZIP file kitodo.zip which includes kitodo-3.7.0-SNAPSHOT.war (which itself is a ZIP file).

@henning-gerhardt
Copy link
Collaborator

What are the benefit to have this except more used space inside the CI build artifacts which is never or only after a long time get deleted in any active fork?

@stweil
Copy link
Member Author

stweil commented Jul 18, 2024

Build artifacts are deleted automatically, and it is also possible to specify the retention time from 1 up to 90 days (which is the default) if this is desired. Project maintainers can also delete artifacts manually.

The war file which was created by the CI can be downloaded and used locally for tests.

@stweil
Copy link
Member Author

stweil commented Jul 19, 2024

Vielleicht sollten wir weitere Artefakte bereitstellen, z. B. die failsafe-reports:

Error:  Please refer to /home/runner/work/kitodo-production/kitodo-production/Kitodo/target/failsafe-reports for the individual test results.

@henning-gerhardt
Copy link
Collaborator

Build artifacts are deleted automatically, and it is also possible to specify the retention time from 1 up to 90 days (which is the default) if this is desired. Project maintainers can also delete artifacts manually.

Maybe this is here not configured as I can access 1.260 executed CI actions which goes back at least one year. Currently a war file is more then 130 MB big and then you can calculate how much storage is needed / reserved to provide this files. This is only on this repository. I did not count on how many more fork repositories the same or even more CI runs are executed.

The war file which was created by the CI can be downloaded and used locally for tests.

Who need this files? As a developer I can create the war file much faster then let a CI action execute and downloading this file. As an admin I would go to my (contract) developer of choice that he / she / it can provide me this file if needed. Using this file to run local tests should be done carefully as they contain maybe changes which are still under development or not stable as you expect.

Vielleicht sollten wir weitere Artefakte bereitstellen, z. B. die failsafe-reports:

This (failsafe-reports) could be a valid point but I think there are already existing mechanism to get the content of the reports better displayed then now and who would download so many single report files?

In my opinion as my last comment here:

  • providing the generated war file by CI execution did not solve any real problem and wasting space here on GitHub for all Kitodo.Production based repositories.
  • if there is a better reporting needed on which test is failing then this should be solved by a better reporting tool and mechanism.

@stweil
Copy link
Member Author

stweil commented Jul 19, 2024

Maybe this is here not configured as I can access 1.260 executed CI actions which goes back at least one year.

Lieber Henning, probiere es bitte aus. Du wirst keine Logdaten sehen, die älter als 90 Tage sind. Lediglich grobe Metadaten sind dann noch sichtbar.

@stweil
Copy link
Member Author

stweil commented Jul 19, 2024

This (failsafe-reports) could be a valid point but I think there are already existing mechanism to get the content of the reports better displayed then now and who would download so many single report files?

Momentan kenne ich keinen existierenden Weg, wie man an den ausführlichen Bericht kommen kann. Eine ZIP-Datei mit den wenigen benötigten Berichten würde ich daher gerne herunterladen, lokal auspacken und mir dann den gewünschten Bericht anschauen.

@henning-gerhardt
Copy link
Collaborator

Lieber Henning, probiere es bitte aus. Du wirst keine Logdaten sehen, die älter als 90 Tage sind. Lediglich grobe Metadaten sind dann noch sichtbar.

Even if this is true and the files are "only" available for a shorter time period this is a waste of space even for this time.

@henning-gerhardt
Copy link
Collaborator

Momentan kenne ich keinen existierenden Weg, wie man an den ausführlichen Bericht kommen kann. Eine ZIP-Datei mit den wenigen benötigten Berichten würde ich daher gerne herunterladen, lokal auspacken und mir dann den gewünschten Bericht anschauen.

Running the tests on your local system is no way for you? If no then why should everyone do this only for you?

@henning-gerhardt
Copy link
Collaborator

I'm stop here to comment and to read as again this is a circle discussion.

@stweil stweil removed the request for review from solth September 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants