-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Store Kitodo war file as build artifact for download #6128
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Stefan Weil <[email protected]>
See example. CI artifacts are always ZIP files. In this case it is the ZIP file kitodo.zip which includes kitodo-3.7.0-SNAPSHOT.war (which itself is a ZIP file). |
What are the benefit to have this except more used space inside the CI build artifacts which is never or only after a long time get deleted in any active fork? |
Build artifacts are deleted automatically, and it is also possible to specify the retention time from 1 up to 90 days (which is the default) if this is desired. Project maintainers can also delete artifacts manually. The war file which was created by the CI can be downloaded and used locally for tests. |
Vielleicht sollten wir weitere Artefakte bereitstellen, z. B. die failsafe-reports:
|
Maybe this is here not configured as I can access 1.260 executed CI actions which goes back at least one year. Currently a war file is more then 130 MB big and then you can calculate how much storage is needed / reserved to provide this files. This is only on this repository. I did not count on how many more fork repositories the same or even more CI runs are executed.
Who need this files? As a developer I can create the war file much faster then let a CI action execute and downloading this file. As an admin I would go to my (contract) developer of choice that he / she / it can provide me this file if needed. Using this file to run local tests should be done carefully as they contain maybe changes which are still under development or not stable as you expect.
This (failsafe-reports) could be a valid point but I think there are already existing mechanism to get the content of the reports better displayed then now and who would download so many single report files? In my opinion as my last comment here:
|
Lieber Henning, probiere es bitte aus. Du wirst keine Logdaten sehen, die älter als 90 Tage sind. Lediglich grobe Metadaten sind dann noch sichtbar. |
Momentan kenne ich keinen existierenden Weg, wie man an den ausführlichen Bericht kommen kann. Eine ZIP-Datei mit den wenigen benötigten Berichten würde ich daher gerne herunterladen, lokal auspacken und mir dann den gewünschten Bericht anschauen. |
Even if this is true and the files are "only" available for a shorter time period this is a waste of space even for this time. |
Running the tests on your local system is no way for you? If no then why should everyone do this only for you? |
I'm stop here to comment and to read as again this is a circle discussion. |
No description provided.