Update some dependencies to latest bugfix versions and more commits related to dependencies #6152
Conversation
|
The CI test failure is unrelated to this pull request, see #6138. |
stweil
force-pushed
the
dependencies
branch
2 times, most recently
from
43cc244
to
f7d4ee9
Compare
|
I added a commit which adds the missing "test" scope to some dependencies which are only relevant for the tests. |
stweil
force-pushed
the
dependencies
branch
3 times, most recently
from
53f242b
to
6fd113a
Compare
stweil
changed the title
| @@ -56,6 +56,7 @@ | |||
| <dependency> | |||
| <groupId>org.hamcrest</groupId> | |||
| <artifactId>hamcrest</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Not needed as defined in parent as test scope.
There was a problem hiding this comment.
I only fixed issues reported by the dependency check ...
This also applies to the other locations where I added the test scope as suggested by this check.
There was a problem hiding this comment.
I get no issues on running different dependency checks. So maybe your tooling is to new? Or how did you get this issues.
There was a problem hiding this comment.
See commit description: "The missing scopes were reported by mvn dependency:analyze."
There was a problem hiding this comment.
And again: I'm not getting this missing scopes report:
[INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ kitodo-data-editor ---
Unable to process: org.kitodo.dataeditor.MetsKitodoConverter
Unable to process: org.kitodo.dataeditor.MetsKitodoWrapper
Unable to process: org.kitodo.dataeditor.VersionProvider
Unable to process: org.kitodo.dataeditor.ruleset.KeyView
Unable to process: org.kitodo.dataeditor.ruleset.xml.Ruleset
Unable to process: org.kitodo.dataeditor.ruleset.xml.EditingElement
Unable to process: org.kitodo.dataeditor.ruleset.xml.ConditionsMap
Unable to process: org.kitodo.dataeditor.ruleset.Rule
Unable to process: org.kitodo.dataeditor.ruleset.DivisionDeclaration
Unable to process: org.kitodo.dataeditor.ruleset.RulesetManagement
Unable to process: org.kitodo.dataeditor.ruleset.KeyDeclaration
Unable to process: org.kitodo.dataeditor.ruleset.Labeled
Unable to process: org.kitodo.dataeditor.ruleset.Settings
Unable to process: org.kitodo.dataeditor.ruleset.NestedKeyView
Unable to process: org.kitodo.dataeditor.entities.FileSec
Unable to process: org.kitodo.dataeditor.entities.PhysicalStructMapType
Unable to process: org.kitodo.dataeditor.entities.LogicalStructMapType
Unable to process: org.kitodo.dataeditor.JaxbXmlUtils
Unable to process: org.kitodo.dataeditor.MetsKitodoReader
Unable to process: org.kitodo.dataeditor.DataEditorTest
Unable to process: org.kitodo.dataeditor.MetsKitodoWriterTest
Unable to process: org.kitodo.dataeditor.ruleset.RulesetManagementIT
Unable to process: org.kitodo.dataeditor.MetsKitodoWrapperTest
[WARNING] Used undeclared dependencies found:
[WARNING] commons-io:commons-io:jar:2.11.0:provided
[WARNING] org.junit.jupiter:junit-jupiter-api:jar:5.9.2:test
[WARNING] Unused declared dependencies found:
[WARNING] org.junit.jupiter:junit-jupiter-engine:jar:5.9.2:test
[WARNING] org.hamcrest:hamcrest:jar:2.2-rc1:test
edit: With my knowledge it is not needed to adjust the scopes in sub-modules if they are the same as in the parent defined scope except you want an other use scope in a sub-module.
| @@ -47,6 +47,7 @@ | |||
| <dependency> | |||
| <groupId>org.hamcrest</groupId> | |||
| <artifactId>hamcrest</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Not needed as defined in parent as test scope.
| @@ -43,6 +43,7 @@ | |||
| <dependency> | |||
| <groupId>org.hamcrest</groupId> | |||
| <artifactId>hamcrest</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Not needed as defined in parent as test scope.
| @@ -233,6 +233,7 @@ | |||
| <dependency> | |||
| <groupId>org.xmlunit</groupId> | |||
| <artifactId>xmlunit-matchers</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Not needed as defined in parent as test scope.
There was a problem hiding this comment.
I don't see a test scope for xmlunit-matchers in my latest pom.xml.
There was a problem hiding this comment.
You add the right scope in your current pull request and as the scopes are passed to the sub modules you did not define it again. As already written in my post above.
pom.xml
Outdated
| <primefaces.extensions.version>8.0.5</primefaces.extensions.version> | ||
| <saxon.version>9.9.1-8</saxon.version> | ||
| <log4j.version>2.19.0</log4j.version> | ||
| <junit.version>5.9.2</junit.version> | ||
| <elasticsearch.version>7.17.10</elasticsearch.version> | ||
| <elasticsearch.version>7.17.24</elasticsearch.version> |
There was a problem hiding this comment.
Why you are changing this version after pull request #6250 is already open which contains this change?
There was a problem hiding this comment.
There would be a conflict otherwise.
There was a problem hiding this comment.
@solth, @henning-gerhardt, GitHub's Dependabot suggests a syntax like <version>[2.14.0,)</version> (not here, but for commons-io:commons-io. Did you ever test this variant? Would [7.17.24,) instead of 7.17.24 work here and automatically use the very latest patch version?
There was a problem hiding this comment.
So far as I know this notation is not wanted as it introduce new issues as everyone is using different version of the same artifact.
|
Ignore my review and this should be reviewed by an other person. |
The updates were selected from this list:
mvn versions:display-dependency-updates | grep -- "->" | sort | uniq
Signed-off-by: Stefan Weil <[email protected]>
These updates were suggested by claude.ai. Signed-off-by: Stefan Weil <[email protected]>
The missing scopes were reported by `mvn dependency:analyze`. Signed-off-by: Stefan Weil <[email protected]>
The updates were selected from this list: