Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update catalog metadata #6233

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

solth
Copy link
Member

@solth solth commented Sep 24, 2024

This pull request adds the feature to re-import metadata of individual processes from a configured catalog search interface using a new button in the metadata editors metadata panel:

Bildschirmfoto 2024-09-24 um 15 57 31

If any differences are detected when comparing the newly imported metadata to that in the existing Kitodo process, the user is presented with a dialog listing all detected changes:

Bildschirmfoto 2024-09-24 um 15 59 02

Using the arrow button between the old and new values, the user can decide to either keep the value currently in Kitodo, replace it with the updated value from the source or use both values. The selection can be changed by clicking on the arrow symbol between old and new values:

Bildschirmaufnahme.2024-09-24.um.16.01.49.mp4

If the process does not contain the functional metadata of type recordIdentifier - whose value is used to load the same data record from the source - or isn't assigned an import configuration of type OPAC_SEARCH, the button to re-import metadata is deactivated:

Bildschirmfoto 2024-09-24 um 16 05 26

Import configurations are now automatically assigned to newly created processes, but in ordner to adjust old processes for metadata re-import a new list action has been added that can be used to assign a specific import configuration to all processes selected in the process list:

Bildschirmfoto 2024-09-24 um 16 10 57

In the following dialog the user can select the import configuration to assign to all selected processes:

Bildschirmfoto 2024-09-24 um 16 11 25

Note: Two new permissions have been added for a) re-importing metadata and b) setting import configurations for selected processes. Since these permissions are not set to any role by default, system admins have to assign these permissions after updating their Kitodo installtion before being able to use the function added in this pull request.

Note 2: One aspect of the original description here that had to be implemented differently was the way metadata groups are displayed in the comparison popup dialog. Since it is not possible to determine whether one metadata group is a new group or an old group with some/most/all metadata entries changed, it is not possible to show just changed values. Instead, the implemention now shows all fields of all metadata groups when differences have been detected in one type of metadata group, so the user can make an educated decision whether he wants to keep the old values or replace them with the new values.

Note 3: during implementation of this function a bug was discovered that corrupts data of collapsed metadata groups in the metadata editor which is documented in #6231. A potential fix has been provided with #6232 but that has not been reviewed or merged into the code, yet, so reviewers testing the metadata re-import of this pull request should keep that in mind and not collapse any metadata groups while testing this new feature.

Fixes #6225

@solth
Copy link
Member Author

solth commented Sep 25, 2024

@BartChris would you mind doing a review for this pull request?

@BartChris
Copy link
Collaborator

@solth Yes, sure.

@solth
Copy link
Member Author

solth commented Sep 25, 2024

@solth Yes, sure.

Thank you! (Already requested review from you 😁)

@solth solth removed the request for review from thomaslow September 25, 2024 15:13
@solth solth marked this pull request as draft September 27, 2024 13:44
@solth
Copy link
Member Author

solth commented Sep 27, 2024

Converted to "Draft" to incorporate change requests made by @subhhwendt

@solth solth force-pushed the update-catalog-metadata branch 2 times, most recently from 0b56f87 to 28738eb Compare October 2, 2024 10:01
@solth solth marked this pull request as ready for review October 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metadata
3 participants