Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Multi-Zim Search #1218

Open
wants to merge 9 commits into
base: Issue#413-search-UI-improvement
Choose a base branch
from

Conversation

ShaopengLin
Copy link
Collaborator

@ShaopengLin ShaopengLin commented Sep 28, 2024

Fixes (part of) #413

Relies on #1189

Changes:

  • Added MultiZim button to SearchBar
  • Popup shows a list of Zims that could be searched. The selection is singular as we do not have *true multi-zim search (yet).
  • Users can now search a different zim than the current tab.
  • Added placeholder UI for 'select-all' button. Hidden for now until *true multi-zim search is implemented.

User can search zim other than the current tab.
Missing this reason cause completer to do nothing
Disabled until true Multizim implemented.
Stretch to fit space and even spacing between items.
Checkmark of select-all and zims to the end of list.
Previously only checks when clicking Radiobutton
Add Custom elide marker
@ShaopengLin ShaopengLin changed the title Issue#413 multizim Introduce Multi-Zim Search Sep 28, 2024
@kelson42 kelson42 added this to the 2.4.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

2 participants