-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipv6 support to local server #1221
base: main
Are you sure you want to change the base?
Conversation
a3ba96e
to
29a8d53
Compare
29a8d53
to
a27c1b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have compiled with libkiwix #1132 and even if I see now ::1
in the list, each time I start the server, then whole kiwix-desktop crashes. Actually this is the same with kiwix-desktop main
.
a27c1b9
to
1492c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected from a user perspective. Ready for code review.
I would like to do some additional checks here before reviews, if possible. |
1492c17
to
1391708
Compare
@veloman-yunkan this is ready for code review. P.S. It would be good for testing even to have in place the fix of |
So I guess this is the last PR of our IPv6 effort :) |
Now that ipv6 works correctly on Windows give me some additional time to catch any issues before we close this up please |
It would be good to merge kiwix/libkiwix#1151 first, as noted here, before finalizing this as well. |
It seems like the root cause helping the discovery of kiwix/libkiwix#1148 is the fact that the Kiwix Desktop local server uses @veloman-yunkan should I filter these out when adding to the list, or should we modify the |
@sgourdas Neither seems a good option to me. Why don't we present the full list of IPs to the users and let them find out which one works best for them? We can add a note that not all of the IPs in the list may actually work. We can filter the list later after we have enough experience with problematic IPs and/or complaints from our users. |
I can see that being best in a "text box scenario" where the input is coming from the user. IMHO if an option is given from a dropdown it should work correctly and have a reason to be presented/add clutter in our app. On the other hand, filtering after we get more experience with problematic IPs is a good approach. But despite that, this prefix seems to get in the way and kind of obscure what works and what doesn't with how many IPs it provides. |
@sgourdas If you can do some research, find out the peculiarity of |
@veloman-yunkan 169.254.0.0/16 addresses are link local addresses which IMO should be excluded in |
The corresponding change should also be probably done in |
@sgourdas Can you provide a reference to some document supporting your statement? |
Such addresses are not globally routable, but they should be usable within the local subnetwork, in which respect they are no different from, for example, 192.168.x.x addresses. |
@veloman-yunkan main sources of my response were this and this. |
This adds ipv6 support to the local kiwix server of the app.
Fixes #1119