Adapt kiwix-tools to new libkiwix API. #580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
approved these changes
Oct 19, 2022
|
@mgautierfr What should we do with this PR? |
veloman-yunkan
requested changes
Nov 3, 2022
There was a problem hiding this comment.
Since kiwix/libkiwix#830 has been replaced (for the time being) by kiwix/libkiwix#837, this PR has to be updated or a new (smaller) PR must be created.
kiwix-tools compile correctly on my computer with both libkiwix and kiwix-tools' s This PR is useful only for kiwix/libkiwix#830, there is nothing to do on kiwix-tools side. We can keep this PR around until (if) we adapt kiwix/libkiwix#830 or we can close it as the new API will be different anyway than what I came with the kiwix's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt code to kiwix/libkiwix#830