Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI on Linux (aarch64, focal) #1145

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix broken CI on Linux (aarch64, focal) #1145

merged 1 commit into from
Oct 3, 2024

Conversation

veloman-yunkan
Copy link
Collaborator

Should fix #1143

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.45%. Comparing base (8bbda99) to head (f6df234).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/server/internalServer.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   41.42%   41.45%   +0.02%     
==========================================
  Files          59       59              
  Lines        4268     4270       +2     
  Branches     2336     2336              
==========================================
+ Hits         1768     1770       +2     
  Misses        999      999              
  Partials     1501     1501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veloman-yunkan
Copy link
Collaborator Author

The fix is now being validated by kiwix/kiwix-build#712. In that PR I observed the Linux(aarch64+focal) jobs fail, then fixed the compilation and verified the fix by re-running the failed jobs. Then I started a fresh run of all CI jobs to make sure that the fix doesn't break something else (the run is now in progress).

@veloman-yunkan
Copy link
Collaborator Author

kiwix-build CI passed - see https://github.com/kiwix/kiwix-build/actions/runs/11162493037?pr=759

@kelson42
Copy link
Collaborator

kelson42 commented Oct 3, 2024

@veloman-yunkan Thx, I will merge ASAP

@kelson42 kelson42 merged commit 4a1498d into main Oct 3, 2024
15 checks passed
@kelson42 kelson42 deleted the ci_fix branch October 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Kiwix-Build CI/CD crashes on libkiwix on aarch64
2 participants