Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer error in forwarder from file #733

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jun 3, 2024

err is nil.

`err` is `nil`.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from cardil and upodroid June 3, 2024 13:24
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/cc @Cali0707 @Leo6Leo

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo June 3, 2024 13:25
@pierDipi pierDipi requested review from mgencur and maschmid June 3, 2024 13:32
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
Copy link

knative-prow bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1f340aa into knative-extensions:main Jun 3, 2024
24 of 26 checks passed
@pierDipi pierDipi deleted the remove-nil-error branch June 3, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants