Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure OIDC subject name for eventshub sender #749

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Aug 12, 2024

Adds an option to set the OIDC identity to use for the eventshub sender

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@knative-prow knative-prow bot requested a review from upodroid August 12, 2024 14:39
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2024
@creydr
Copy link
Contributor Author

creydr commented Aug 12, 2024

@dsimansk could you PTAL? This is helpful for knative/eventing#8150

@creydr
Copy link
Contributor Author

creydr commented Aug 12, 2024

Error: init failed to get project from boskos: failed to get a "gke-project" from boskos: resources not found

/test integration-tests

@creydr
Copy link
Contributor Author

creydr commented Aug 12, 2024

/cc @Cali0707 @Leo6Leo

pkg/eventshub/options.go Outdated Show resolved Hide resolved
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
Copy link

knative-prow bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fc8ca94 into knative-extensions:main Aug 12, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants