Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resource already exists in Apply #759

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 24, 2024

We're getting already exists errors when applying the same resource in parallel tests.

    logger.go:146: 2024-09-20T11:05:08.890Z	FATAL	environment/magic.go:243	failed to install CA certificates and issuer: failed to create resource certificates.cert-manager.io "selfsigned-ca" already exists - Resource:
        apiVersion: cert-manager.io/v1
        kind: Certificate
        metadata:
          name: selfsigned-ca
          namespace: serverless-tests
        spec:
          commonName: selfsigned-ca
          isCA: true
          issuerRef:
            group: cert-manager.io
            kind: Issuer
            name: selfsigned-issuer
          privateKey:
            algorithm: ECDSA
            size: 256
          secretName: eventshub-ca
        	{"test": "TestPingSourceTLS"}

We're getting already exists errors when applying the
same resource in parallel tests.

```
    logger.go:146: 2024-09-20T11:05:08.890Z	FATAL	environment/magic.go:243	failed to install CA certificates and issuer: failed to create resource certificates.cert-manager.io "selfsigned-ca" already exists - Resource:
        apiVersion: cert-manager.io/v1
        kind: Certificate
        metadata:
          name: selfsigned-ca
          namespace: serverless-tests
        spec:
          commonName: selfsigned-ca
          isCA: true
          issuerRef:
            group: cert-manager.io
            kind: Issuer
            name: selfsigned-issuer
          privateKey:
            algorithm: ECDSA
            size: 256
          secretName: eventshub-ca
        	{"test": "TestPingSourceTLS"}
```

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link

knative-prow bot commented Sep 24, 2024

@pierDipi: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

We're getting already exists errors when applying the same resource in parallel tests.

   logger.go:146: 2024-09-20T11:05:08.890Z	FATAL	environment/magic.go:243	failed to install CA certificates and issuer: failed to create resource certificates.cert-manager.io "selfsigned-ca" already exists - Resource:
       apiVersion: cert-manager.io/v1
       kind: Certificate
       metadata:
         name: selfsigned-ca
         namespace: serverless-tests
       spec:
         commonName: selfsigned-ca
         isCA: true
         issuerRef:
           group: cert-manager.io
           kind: Issuer
           name: selfsigned-issuer
         privateKey:
           algorithm: ECDSA
           size: 256
         secretName: eventshub-ca
       	{"test": "TestPingSourceTLS"}

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@pierDipi
Copy link
Member Author

/cherry-pick release-1.15

@knative-prow-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 13c0118 into knative-extensions:main Sep 24, 2024
25 of 26 checks passed
@knative-prow-robot
Copy link

@pierDipi: new pull request created: #760

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link

@pierDipi: new pull request created: #761

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants