Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

[kn-admin] Add Unit Test and e2e test #14

Open
zhanggbj opened this issue Apr 14, 2020 · 3 comments
Open

[kn-admin] Add Unit Test and e2e test #14

zhanggbj opened this issue Apr 14, 2020 · 3 comments

Comments

@zhanggbj
Copy link

For kn-admin plugin, use go test framework to fill up Unit Test and e2e test.

@zhanggbj
Copy link
Author

UT merged with #14 by @lanceliuu
Xu, any plan for e2e?

@xliuxu
Copy link
Contributor

xliuxu commented May 29, 2020

Progress for adding unit test & e2e test:
The unit tests part is done in PR #31

?       knative.dev/client-contrib/plugins/admin/cmd    [no test files]
ok      knative.dev/client-contrib/plugins/admin/core   4.482s  coverage: 50.0% of statements
?       knative.dev/client-contrib/plugins/admin/pkg    [no test files]
ok      knative.dev/client-contrib/plugins/admin/pkg/command    1.203s  coverage: 100.0% of statements
ok      knative.dev/client-contrib/plugins/admin/pkg/command/domain     2.188s  coverage: 97.7% of statements
ok      knative.dev/client-contrib/plugins/admin/pkg/command/registry   4.872s  coverage: 94.9% of statements
?       knative.dev/client-contrib/plugins/admin/pkg/testutil   [no test files]

I will continue to add e2e tests in another pull request.

@zhanggbj
Copy link
Author

zhanggbj commented Jul 19, 2020

e2e which need to fill up
Autoscaling

  • autoscaling update --scale-to-zero @zhanggbj
  • autoscaling update --no-scale-to-zero @zhanggbj

Domain

  • domain set @lanceliuu
  • domain set with selector @lanceliuu
  • domain unset @lanceliuu

Registry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants