Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding yijie-04 as community member #1526

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

yijie-04
Copy link
Contributor

@yijie-04 yijie-04 commented Mar 4, 2024

Adding myself as a community member since I'm an incoming mentee for the LFX project.

I've opened this PR:
knative/eventing#7527

and I've also helped this PR:
knative/eventing#7525

@knative-prow knative-prow bot requested review from dsimansk and krsna-m March 4, 2024 21:11
Copy link

knative-prow bot commented Mar 4, 2024

Welcome @yijie-04! It looks like this is your first PR to knative/community 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2024
Copy link

knative-prow bot commented Mar 4, 2024

Hi @yijie-04. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2024
@Cali0707
Copy link
Member

Cali0707 commented Mar 4, 2024

/ok-to-test
LGTM from me, welcome to the community @yijie-04 !

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team March 4, 2024 21:12
@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 4, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

knative-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@knative-prow knative-prow bot merged commit 5481c13 into knative:main Mar 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants