Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rahulii as knative member #1589

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

rahulii
Copy link
Contributor

@rahulii rahulii commented Jul 2, 2024

Adding myself as a knative member so I don't have to wait for the ok-to-test labels.

Contributions so far:

Copy link

knative-prow bot commented Jul 2, 2024

Welcome @rahulii! It looks like this is your first PR to knative/community 🎉

Copy link

knative-prow bot commented Jul 2, 2024

Hi @rahulii. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2024
@rahulii rahulii changed the title Add rahulii as knative member Add rahulii as knative member (only knative and not knative-sandbox) Jul 2, 2024
@rahulii rahulii changed the title Add rahulii as knative member (only knative and not knative-sandbox) Add rahulii as knative member Jul 2, 2024
Signed-off-by: rahulii <[email protected]>
@creydr
Copy link
Member

creydr commented Jul 2, 2024

Thanks for your contributions so far @rahulii
/lgtm

/assign @dsimansk

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@creydr
Copy link
Member

creydr commented Jul 2, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2024
@creydr
Copy link
Member

creydr commented Jul 2, 2024

/cc @knative/technical-oversight-committee

@dprotaso
Copy link
Member

dprotaso commented Jul 2, 2024

/lgtm
/approve

Copy link

knative-prow bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@knative-prow knative-prow bot merged commit aec4821 into knative:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants